Add Type::isVoid()

src/Analyser/NodeScopeResolver.php

@@ -150,7 +150,6 @@
 use PHPStan\Type\TypeUtils;
 use PHPStan\Type\TypeWithClassName;
 use PHPStan\Type\UnionType;
-use PHPStan\Type\VoidType;
 use Throwable;
 use Traversable;
 use TypeError;
@@ -1498,7 +1497,7 @@ private function getOverridingThrowPoints(Node\Stmt $statement, MutatingScope $s
 			$throwsTag = $resolvedPhpDoc->getThrowsTag();
 			if ($throwsTag !== null) {
 				$throwsType = $throwsTag->getType();
-				if ($throwsType instanceof VoidType) {
+				if ($throwsType->isVoid()->yes()) {
 					return [];
 				}
 
@@ -2820,7 +2819,7 @@ private function getFunctionThrowPoint(
 		}
 
 		if ($throwType !== null) {
-			if (!$throwType instanceof VoidType) {
+			if (!$throwType->isVoid()->yes()) {
 				return ThrowPoint::createExplicit($scope, $throwType, $funcCall, true);
 			}
 		} elseif ($this->implicitThrows) {
@@ -2878,7 +2877,7 @@ private function getMethodThrowPoint(MethodReflection $methodReflection, Paramet
 		}
 
 		if ($throwType !== null) {
-			if (!$throwType instanceof VoidType) {
+			if (!$throwType->isVoid()->yes()) {
 				return ThrowPoint::createExplicit($scope, $throwType, $methodCall, true);
 			}
 		} elseif ($this->implicitThrows) {
@@ -2915,7 +2914,7 @@ private function getConstructorThrowPoint(MethodReflection $constructorReflectio
 
 		if ($constructorReflection->getThrowType() !== null) {
 			$throwType = $constructorReflection->getThrowType();
-			if (!$throwType instanceof VoidType) {
+			if (!$throwType->isVoid()->yes()) {
 				return ThrowPoint::createExplicit($scope, $throwType, $new, true);
 			}
 		} elseif ($this->implicitThrows) {
@@ -2947,7 +2946,7 @@ private function getStaticMethodThrowPoint(MethodReflection $methodReflection, P
 
 		if ($methodReflection->getThrowType() !== null) {
 			$throwType = $methodReflection->getThrowType();
-			if (!$throwType instanceof VoidType) {
+			if (!$throwType->isVoid()->yes()) {
 				return ThrowPoint::createExplicit($scope, $throwType, $methodCall, true);
 			}
 		} elseif ($this->implicitThrows) {

src/Reflection/Native/NativeFunctionReflection.php

@@ -7,7 +7,6 @@
 use PHPStan\Reflection\ParametersAcceptorWithPhpDocs;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Type;
-use PHPStan\Type\VoidType;
 
 class NativeFunctionReflection implements FunctionReflection
 {
@@ -89,7 +88,7 @@ public function hasSideEffects(): TrinaryLogic
 	private function isVoid(): bool
 	{
 		foreach ($this->variants as $variant) {
-			if (!$variant->getReturnType() instanceof VoidType) {
+			if (!$variant->getReturnType()->isVoid()->yes()) {
 				return false;
 			}
 		}

src/Reflection/Native/NativeMethodReflection.php

@@ -13,7 +13,6 @@
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypehintHelper;
-use PHPStan\Type\VoidType;
 use ReflectionException;
 use function strtolower;
 
@@ -144,7 +143,7 @@ public function hasSideEffects(): TrinaryLogic
 	private function isVoid(): bool
 	{
 		foreach ($this->variants as $variant) {
-			if (!$variant->getReturnType() instanceof VoidType) {
+			if (!$variant->getReturnType()->isVoid()->yes()) {
 				return false;
 			}
 		}

src/Reflection/Php/PhpFunctionFromParserNodeReflection.php

@@ -19,7 +19,6 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypehintHelper;
-use PHPStan\Type\VoidType;
 use function array_reverse;
 use function is_array;
 use function is_string;
@@ -194,7 +193,7 @@ public function getThrowType(): ?Type
 
 	public function hasSideEffects(): TrinaryLogic
 	{
-		if ($this->getReturnType() instanceof VoidType) {
+		if ($this->getReturnType()->isVoid()->yes()) {
 			return TrinaryLogic::createYes();
 		}
 		if ($this->isPure !== null) {

src/Reflection/Php/PhpFunctionReflection.php

@@ -24,7 +24,6 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypehintHelper;
-use PHPStan\Type\VoidType;
 use function array_map;
 use function filemtime;
 use function is_file;
@@ -240,7 +239,7 @@ public function getThrowType(): ?Type
 
 	public function hasSideEffects(): TrinaryLogic
 	{
-		if ($this->getReturnType() instanceof VoidType) {
+		if ($this->getReturnType()->isVoid()->yes()) {
 			return TrinaryLogic::createYes();
 		}
 		if ($this->isPure !== null) {

src/Reflection/Php/PhpMethodReflection.php

@@ -405,12 +405,9 @@ public function getThrowType(): ?Type
 
 	public function hasSideEffects(): TrinaryLogic
 	{
-		$name = strtolower($this->getName());
-		$isVoid = $this->getReturnType() instanceof VoidType;
-
 		if (
-			$name !== '__construct'
-			&& $isVoid
+			strtolower($this->getName()) !== '__construct'
+			&& $this->getReturnType()->isVoid()->yes()
 		) {
 			return TrinaryLogic::createYes();
 		}

src/Rules/Comparison/ImpossibleCheckTypeHelper.php

@@ -24,7 +24,6 @@
 use PHPStan\Type\TypeUtils;
 use PHPStan\Type\TypeWithClassName;
 use PHPStan\Type\VerbosityLevel;
-use PHPStan\Type\VoidType;
 use function array_map;
 use function array_pop;
 use function count;
@@ -331,7 +330,7 @@ private function determineContext(Scope $scope, Expr $node): TypeSpecifierContex
 				$parametersAcceptor = ParametersAcceptorSelector::selectFromArgs($scope, $node->getArgs(), $functionReflection->getVariants());
 				$returnType = TypeUtils::resolveLateResolvableTypes($parametersAcceptor->getReturnType());
 
-				return $returnType instanceof VoidType ? TypeSpecifierContext::createNull() : TypeSpecifierContext::createTruthy();
+				return $returnType->isVoid()->yes() ? TypeSpecifierContext::createNull() : TypeSpecifierContext::createTruthy();
 			}
 		} elseif ($node instanceof MethodCall && $node->name instanceof Node\Identifier) {
 			$methodCalledOnType = $scope->getType($node->var);
@@ -340,7 +339,7 @@ private function determineContext(Scope $scope, Expr $node): TypeSpecifierContex
 				$parametersAcceptor = ParametersAcceptorSelector::selectFromArgs($scope, $node->getArgs(), $methodReflection->getVariants());
 				$returnType = TypeUtils::resolveLateResolvableTypes($parametersAcceptor->getReturnType());
 
-				return $returnType instanceof VoidType ? TypeSpecifierContext::createNull() : TypeSpecifierContext::createTruthy();
+				return $returnType->isVoid()->yes() ? TypeSpecifierContext::createNull() : TypeSpecifierContext::createTruthy();
 			}
 		} elseif ($node instanceof StaticCall && $node->name instanceof Node\Identifier) {
 			if ($node->class instanceof Node\Name) {
@@ -354,7 +353,7 @@ private function determineContext(Scope $scope, Expr $node): TypeSpecifierContex
 				$parametersAcceptor = ParametersAcceptorSelector::selectFromArgs($scope, $node->getArgs(), $staticMethodReflection->getVariants());
 				$returnType = TypeUtils::resolveLateResolvableTypes($parametersAcceptor->getReturnType());
 
-				return $returnType instanceof VoidType ? TypeSpecifierContext::createNull() : TypeSpecifierContext::createTruthy();
+				return $returnType->isVoid()->yes() ? TypeSpecifierContext::createNull() : TypeSpecifierContext::createTruthy();
 			}
 		}
 

src/Rules/Comparison/UsageOfVoidMatchExpressionRule.php

@@ -6,7 +6,6 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
-use PHPStan\Type\VoidType;
 
 /**
  * @implements Rule<Node\Expr\Match_>
@@ -23,7 +22,7 @@ public function processNode(Node $node, Scope $scope): array
 	{
 		$matchResultType = $scope->getType($node);
 		if (
-			$matchResultType instanceof VoidType
+			$matchResultType->isVoid()->yes()
 			&& !$scope->isInFirstLevelStatement()
 		) {
 			return [RuleErrorBuilder::message('Result of match expression (void) is used.')->build()];

src/Rules/Exceptions/ThrowsVoidFunctionWithExplicitThrowPointRule.php

@@ -12,7 +12,6 @@
 use PHPStan\Type\TypeUtils;
 use PHPStan\Type\TypeWithClassName;
 use PHPStan\Type\VerbosityLevel;
-use PHPStan\Type\VoidType;
 use function sprintf;
 
 /**
@@ -41,7 +40,7 @@ public function processNode(Node $node, Scope $scope): array
 			throw new ShouldNotHappenException();
 		}
 
-		if (!$functionReflection->getThrowType() instanceof VoidType) {
+		if ($functionReflection->getThrowType() === null || !$functionReflection->getThrowType()->isVoid()->yes()) {
 			return [];
 		}
 

src/Rules/Exceptions/ThrowsVoidMethodWithExplicitThrowPointRule.php

@@ -12,7 +12,6 @@
 use PHPStan\Type\TypeUtils;
 use PHPStan\Type\TypeWithClassName;
 use PHPStan\Type\VerbosityLevel;
-use PHPStan\Type\VoidType;
 use function sprintf;
 
 /**
@@ -41,7 +40,7 @@ public function processNode(Node $node, Scope $scope): array
 			throw new ShouldNotHappenException();
 		}
 
-		if (!$methodReflection->getThrowType() instanceof VoidType) {
+		if ($methodReflection->getThrowType() === null || !$methodReflection->getThrowType()->isVoid()->yes()) {
 			return [];
 		}
 

src/Rules/Exceptions/TooWideThrowTypeCheck.php

@@ -8,7 +8,6 @@
 use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\TypeUtils;
 use PHPStan\Type\VerbosityLevel;
-use PHPStan\Type\VoidType;
 use function array_map;
 
 class TooWideThrowTypeCheck
@@ -20,7 +19,7 @@ class TooWideThrowTypeCheck
 	 */
 	public function check(Type $throwType, array $throwPoints): array
 	{
-		if ($throwType instanceof VoidType) {
+		if ($throwType->isVoid()->yes()) {
 			return [];
 		}
 

src/Rules/FunctionCallParametersCheck.php

@@ -23,7 +23,6 @@
 use PHPStan\Type\TypeTraverser;
 use PHPStan\Type\TypeUtils;
 use PHPStan\Type\VerbosityLevel;
-use PHPStan\Type\VoidType;
 use function array_fill;
 use function array_key_exists;
 use function count;
@@ -209,7 +208,7 @@ public function check(
 		}
 
 		if (
-			$scope->getType($funcCall) instanceof VoidType
+			$scope->getType($funcCall)->isVoid()->yes()
 			&& !$scope->isInFirstLevelStatement()
 			&& !$funcCall instanceof Node\Expr\New_
 		) {

src/Rules/FunctionDefinitionCheck.php

@@ -29,7 +29,6 @@
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeTraverser;
 use PHPStan\Type\VerbosityLevel;
-use PHPStan\Type\VoidType;
 use function array_keys;
 use function array_map;
 use function array_merge;
@@ -114,7 +113,7 @@ public function checkAnonymousFunction(
 				throw new ShouldNotHappenException();
 			}
 			$type = $scope->getFunctionType($param->type, false, false);
-			if ($type instanceof VoidType) {
+			if ($type->isVoid()->yes()) {
 				$errors[] = RuleErrorBuilder::message(sprintf($parameterMessage, $param->var->name, 'void'))->line($param->type->getLine())->nonIgnorable()->build();
 			}
 			if (
@@ -260,7 +259,7 @@ private function checkParametersAcceptor(
 				if (!$parameterVar instanceof Variable || !is_string($parameterVar->name)) {
 					throw new ShouldNotHappenException();
 				}
-				if ($parameter->getNativeType() instanceof VoidType) {
+				if ($parameter->getNativeType()->isVoid()->yes()) {
 					$errors[] = RuleErrorBuilder::message(sprintf($parameterMessage, $parameterVar->name, 'void'))->line($parameterNodeCallback()->getLine())->nonIgnorable()->build();
 				}
 				if (

src/Rules/Functions/CallToFunctionStatementWithoutSideEffectsRule.php

@@ -8,7 +8,6 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\NeverType;
-use PHPStan\Type\VoidType;
 use function in_array;
 use function sprintf;
 
@@ -46,7 +45,7 @@ public function processNode(Node $node, Scope $scope): array
 		if ($function->hasSideEffects()->no() || $node->expr->isFirstClassCallable()) {
 			if (!$node->expr->isFirstClassCallable()) {
 				$throwsType = $function->getThrowType();
-				if ($throwsType !== null && !$throwsType instanceof VoidType) {
+				if ($throwsType !== null && !$throwsType->isVoid()->yes()) {
 					return [];
 				}
 			}

src/Rules/Generators/YieldFromTypeRule.php

@@ -14,7 +14,6 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\TypeWithClassName;
 use PHPStan\Type\VerbosityLevel;
-use PHPStan\Type\VoidType;
 use function sprintf;
 
 /**
@@ -127,7 +126,7 @@ public function processNode(Node $node, Scope $scope): array
 			))->build();
 		}
 
-		if ($scope->getType($node) instanceof VoidType && !$scope->isInFirstLevelStatement()) {
+		if ($scope->getType($node)->isVoid()->yes() && !$scope->isInFirstLevelStatement()) {
 			$messages[] = RuleErrorBuilder::message('Result of yield from (void) is used.')->build();
 		}
 

src/Rules/Generators/YieldTypeRule.php

@@ -12,7 +12,6 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\NullType;
 use PHPStan\Type\VerbosityLevel;
-use PHPStan\Type\VoidType;
 use function sprintf;
 
 /**
@@ -77,7 +76,7 @@ public function processNode(Node $node, Scope $scope): array
 				$valueType->describe($verbosityLevel),
 			))->build();
 		}
-		if ($scope->getType($node) instanceof VoidType && !$scope->isInFirstLevelStatement()) {
+		if ($scope->getType($node)->isVoid()->yes() && !$scope->isInFirstLevelStatement()) {
 			$messages[] = RuleErrorBuilder::message('Result of yield (void) is used.')->build();
 		}
 

src/Rules/Methods/CallToConstructorStatementWithoutSideEffectsRule.php

@@ -8,7 +8,6 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\NeverType;
-use PHPStan\Type\VoidType;
 use function sprintf;
 
 /**
@@ -50,7 +49,7 @@ public function processNode(Node $node, Scope $scope): array
 		$constructor = $classReflection->getConstructor();
 		if ($constructor->hasSideEffects()->no()) {
 			$throwsType = $constructor->getThrowType();
-			if ($throwsType !== null && !$throwsType instanceof VoidType) {
+			if ($throwsType !== null && !$throwsType->isVoid()->yes()) {
 				return [];
 			}
 

src/Rules/Methods/CallToMethodStatementWithoutSideEffectsRule.php

@@ -11,7 +11,6 @@
 use PHPStan\Type\ErrorType;
 use PHPStan\Type\NeverType;
 use PHPStan\Type\Type;
-use PHPStan\Type\VoidType;
 use function sprintf;
 
 /**
@@ -65,7 +64,7 @@ public function processNode(Node $node, Scope $scope): array
 		if ($method->hasSideEffects()->no() || $node->expr->isFirstClassCallable()) {
 			if (!$node->expr->isFirstClassCallable()) {
 				$throwsType = $method->getThrowType();
-				if ($throwsType !== null && !$throwsType instanceof VoidType) {
+				if ($throwsType !== null && !$throwsType->isVoid()->yes()) {
 					return [];
 				}
 			}

src/Rules/Methods/CallToStaticMethodStatementWithoutSideEffectsRule.php

@@ -13,7 +13,6 @@
 use PHPStan\Type\NeverType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
-use PHPStan\Type\VoidType;
 use function sprintf;
 use function strtolower;
 
@@ -88,7 +87,7 @@ public function processNode(Node $node, Scope $scope): array
 		if ($method->hasSideEffects()->no() || $node->expr->isFirstClassCallable()) {
 			if (!$node->expr->isFirstClassCallable()) {
 				$throwsType = $method->getThrowType();
-				if ($throwsType !== null && !$throwsType instanceof VoidType) {
+				if ($throwsType !== null && !$throwsType->isVoid()->yes()) {
 					return [];
 				}
 			}