Fix false positive of access to static private property of parent class

[staabm]

closes phpstan/phpstan#8333

[staabm]

just realized that this rule also missed a separate error case, which theAccessPropertiesRule contained in

phpstan-src/src/Rules/Properties/AccessPropertiesRule.php

Lines 124 to 135 in 80ba5a0

	if ($parentClassReflection->hasProperty($name)) {
	if ($scope->canAccessProperty($parentClassReflection->getProperty($name, $scope))) {
	return [];
	}
	return [
	RuleErrorBuilder::message(sprintf(
	'Access to private property $%s of parent class %s.',
	$name,
	$parentClassReflection->getDisplayName(),
	))->build(),
	];
	}

added the missing check and a test

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

1. typeForDescribe is just for error message description
2. instanceof *Type is always wrong

[staabm]

refactored it to make it more like

phpstan-src/src/Rules/Properties/AccessPropertiesRule.php

Lines 119 to 139 in 582a9cb

	if (count($classNames) === 1) {
	$referencedClass = $typeResult->getReferencedClasses()[0];
	$propertyClassReflection = $this->reflectionProvider->getClass($referencedClass);
	$parentClassReflection = $propertyClassReflection->getParentClass();
	while ($parentClassReflection !== null) {
	if ($parentClassReflection->hasProperty($name)) {
	if ($scope->canAccessProperty($parentClassReflection->getProperty($name, $scope))) {
	return [];
	}
	return [
	RuleErrorBuilder::message(sprintf(
	'Access to private property $%s of parent class %s.',
	$name,
	$parentClassReflection->getDisplayName(),
	))->build(),
	];
	}
	$parentClassReflection = $parentClassReflection->getParentClass();
	}
	}

[ondrejmirtes]

This is also wrong. getReferencedClasses will return nested classes too. Which means that if you get Foo<Bar>, getReferencedClasses will contain both Foo and Bar.

I think that in context of this PR, you need TypeUtils::getDirectClassNames. Feel free to fix the other PR too.

[staabm]

at this point I just did what you said. I don't know what I am doing here right now.

Feel free to fix the other PR too.

not sure which one you mean.

I will be in a meeting for the rest of the day. would be great in case you already know what needs to be done, if you could finish it.

thank you

[ondrejmirtes]

You said: refactored it to make it more like

phpstan-src/src/Rules/Properties/AccessPropertiesRule.php

Lines 119 to 139 in 582a9cb

	if (count($classNames) === 1) {
	$referencedClass = $typeResult->getReferencedClasses()[0];
	$propertyClassReflection = $this->reflectionProvider->getClass($referencedClass);
	$parentClassReflection = $propertyClassReflection->getParentClass();
	while ($parentClassReflection !== null) {
	if ($parentClassReflection->hasProperty($name)) {
	if ($scope->canAccessProperty($parentClassReflection->getProperty($name, $scope))) {
	return [];
	}
	return [
	RuleErrorBuilder::message(sprintf(
	'Access to private property $%s of parent class %s.',
	$name,
	$parentClassReflection->getDisplayName(),
	))->build(),
	];
	}
	$parentClassReflection = $parentClassReflection->getParentClass();
	}
	}

But that other rule is wrong too, not sure for how long.

[staabm]

ok. I pushed a fix. hopefully thats what you had in mind.

thank you

[staabm]

But that other rule is wrong too, not sure for how long.

btw: I found the commit staabm@455fb7b

[ondrejmirtes]

Thank you!