Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-working type assertions in NodeScopeResolverTest cases #1992

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Fix non-working type assertions in NodeScopeResolverTest cases #1992

merged 1 commit into from
Nov 11, 2022

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Nov 11, 2022

Discovered via #1991

@herndlm herndlm marked this pull request as ready for review November 11, 2022 14:42
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@herndlm
Copy link
Contributor Author

herndlm commented Nov 11, 2022 •
edited
Loading

because I saw it here - most likely running the issue bot for tests/-only changes is overkill?

@staabm
Copy link
Contributor

staabm commented Nov 11, 2022 •
edited
Loading

Maybe we should have a rule which detects when TypeInferenceTest included files don‘t contain asserts (or doesnt import the function)

@ondrejmirtes ondrejmirtes merged commit 2177d4e into phpstan:1.9.x Nov 11, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@ondrejmirtes
Copy link
Member

Maybe we should have a rule

Done d0207ed

@herndlm herndlm deleted the fix-node-scope-resolver-test-assertions branch November 11, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@herndlm @phpstan-bot @staabm @ondrejmirtes