Improve create conditional expressions to handle all expressions

[rajyan]

This pull request covers
phpstan/phpstan#8360

• Solve the infinite loop problem
• Make createConditionalExpressions work for all expressions

improves result of phpstan/phpstan#4173 but not completely fixed yet

[rajyan]

Issue bot seems not working well. Looks like a cache problem?
This change should notify issue-7705 and issue-4173 changes like in
#1950 (comment)

[staabm]

Issue bot seems not working well. Looks like a cache problem?
This change should notify issue-7705 and issue-4173 changes like in

hmm I have the impression it works:

https://github.com/phpstan/phpstan-src/actions/runs/3488347704

[rajyan]

Oh, thank you for noticing! Not sure what I was looking at...

[rajyan]

@ondrejmirtes
I think the result of issue bot is wrong when there is a infinite loop. issue-7705 was causing an infinite loop before dd478c0 , but the issue bot was saying no error.

[herndlm]

Loops are generalised and skipped after a couple of iterations AFAIK. Could that be related?

[rajyan]

Not that "loop" I think.
This change causes something like
Resolve conditionalExpressionType of $foo => Need to getType of contional $isFoo || $isBar => Resolve type of $isFoo || $isBar => getType of BooleanOr uses filterByFalsyScope => In filterByFalsyScope conditionalExpressionType of $foo is evaluate again...

[herndlm]

Ah sorry, yeah, completely wrong loop I was thinking about.. xD

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

Thank you!

[mvorisek]

This PR seems to cache result of function result 1:1 and retrive the result from cache later. I observed this in phpstan v 1.9.2 (the latest rel).

Is that desired? For count() it is legit and thank you. However for expression like TraitUtil::hasTrait($object, DebugTrait::class) (a custom function) how does php know/guarantee the result will be the same, does it reason it based on the TraitUtil::hasTrait impl or just guess it when the passed args are the same?

[rajyan]

Yes this is intended

how does php know/guarantee the result will be the same

When

• TraitUtil::hasTrait is not marked impure
• The exact same TraitUtil::hasTrait($object, DebugTrait::class) is called
• $object is not invalidated

just guess it when the passed args are the same?

so it's something like that.

[rajyan]

By the way, remembering function results was working before this PR already.
https://phpstan.org/blog/remembering-and-forgetting-returned-values
this PR made them work for more complex conditions too.

[mvorisek]

Thank you, I did not know user functions are "pure"/remembered by default.

[staabm]

See https://phpstan.org/blog/remembering-and-forgetting-returned-values