Group $expressionTypes and $nativeExpressionTypes in Scope creation methods
#2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @rajyan again. I hope this does not cause too many conflicts with whatever you're working on :/ |
|
btw do we also want to adapt the $expressionTypes variable names or is it not worth it? e.g. in some places they are still called variableTypeHolders and such AFAIK |
|
I found a PR from you I can merge without testing locally, so that your withdrawal symptoms go away too :D Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #2021 (comment)
I expect the Rector downgrade to fail again, let's see 🤞. local
makewas green. UPDATE: mysteriously it worked, weird. maybe also moving the phpdoc (which was done by PHPStorm) did something, well, not important as long as it works I guess..