Skip to content

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Dec 10, 2022

running blackfire run php bin/phpstan -vvv --debug on my mac

php -v
PHP 8.1.13 (cli) (built: Nov 24 2022 15:58:42) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.13, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.13, Copyright (c), by Zend Technologies
    with blackfire v1.81.0~mac-x64-non_zts81, https://blackfire.io, by Blackfire

leads to
grafik

@ondrejmirtes ondrejmirtes merged commit 2912ae4 into phpstan:1.9.x Dec 10, 2022
@ondrejmirtes
Copy link
Member

Awesome, thank you!

@staabm staabm deleted the cache-class-doc branch December 10, 2022 09:11
@herndlm
Copy link
Contributor

herndlm commented Dec 10, 2022

Nice! 🎉 I somehow feel very peer-pressured to contribute to the performance improvements as well xD

@staabm
Copy link
Contributor Author

staabm commented Dec 10, 2022

feel very peer-pressured to contribute to the performance improvements as well xD

that was part of my dark plan behind the tweet.

grafik

@staabm
Copy link
Contributor Author

staabm commented Dec 10, 2022

@herndlm I think there is some potential in TypeTraverser but I have no idea yet on how we could get it faster

grafik

most called from

grafik

2nd most called from

grafik

@herndlm
Copy link
Contributor

herndlm commented Dec 10, 2022

We should remove it 😁

@herndlm
Copy link
Contributor

herndlm commented Dec 10, 2022

But jokes aside, there are a couple of misusages of it and I'll get rid of those. Most likely they are not affecting performance much..

@staabm
Copy link
Contributor Author

staabm commented Dec 10, 2022

Perf wise the only 2 relevant ones are these shown above.

But the less the better design wise :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants