Improve performance again by dumbing down nested arrays #2077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
force-pushed
the
dumb-down-arrays
branch
2 times, most recently
from
61642e7 to
a54510a
Compare
ondrejmirtes
force-pushed
the
dumb-down-arrays
branch
from
a54510a to
9cbc5af
Compare
staabm
reviewed
Dec 18, 2022
src/Rules/RuleLevelHelper.php
Outdated
| if (self::accepts($innerType, $acceptedType, $strictTypes)) { | ||
| return true; | ||
| } | ||
| $results[] = self::innerAccepts($innerType, $acceptedType, $strictTypes); |
There was a problem hiding this comment.
it might make sense to use lazyOr so it may early exit
There was a problem hiding this comment.
(or you just return from within the loop on YES)
ondrejmirtes
force-pushed
the
dumb-down-arrays
branch
from
9cbc5af to
cab688b
Compare
|
This pull request has been marked as ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.