Skip to content

Faster ConstantStringType->toArrayKey() #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2022
Merged

Faster ConstantStringType->toArrayKey() #2081

merged 1 commit into from
Dec 11, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Dec 11, 2022

11% speedup of phpstan/phpstan#8504

This file mmarton/phpstan-issue8146@master/src/DataFixtures/LocationFixtures.php from phpstan/phpstan#8146 really slows PHPStan down, because it contains a lot of literal arrays.

grafik

@ondrejmirtes ondrejmirtes merged commit 17896e3 into phpstan:1.9.x Dec 11, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the fast-to-key branch December 11, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @ondrejmirtes