Faster ConstantArrayType->isSuperTypeOf()

[staabm]

23% speedup of phpstan/phpstan#8504

This file mmarton/phpstan-issue8146@master/src/DataFixtures/LocationFixtures.php from phpstan/phpstan#8146 really slows PHPStan down, because it contains a lot of literal arrays.

---

[herndlm]

Suggested change

	return TrinaryLogic::createNo();
	return $isValueSuperType;

should be possible, no? or any other reason why you didn't do that?

[staabm]

createNo is cheap and I like seeing on the first sight without applying any logics what the return type is.

but its the same thing, you are right.

[ondrejmirtes]

Thank you!

[staabm]

@ondrejmirtes we could apply a similar early return NO on NO here:

phpstan-src/src/Type/Generic/GenericObjectType.php

Line 165 in e4a5e98

$results[] = $templateType->isValidVariance($this->types[$i], $ancestor->types[$i]);

I have no concrete perf relevant case to measure it. wdyt?

[ondrejmirtes]

Only if it shows up in Blackfire :) This is gonna run the same number of times as there are @template above a class... so not that many :)

[staabm]

ok.

profiling https://github.com/mmarton/phpstan-issue8146/blob/master/src/DataFixtures/LocationFixtures.php I can see the top consumer is now PhpFileCleaner

this makes me think of #1290 which deletes said PhpFileCleaner class

[ondrejmirtes]

Nope, that's completely unrelated to the arrays, it just means there's a lot of dependencies in vendor and otherwise the project (analysed files) is relatively small.

#1290 is going to be slower than the current solution with PhpFileCleaner.