OptimizedDirectorySourceLocator based only on PhpParser
#1290
Conversation
kukulich
force-pushed
the
optimized
branch
3 times, most recently
from
c7190a4 to
a5cc9dd
Compare
|
@kukulich just found this PR. Is it still relevant? Is there a concrete problem beeing solved here (it looks like its a performance improvement)? |
|
I discussed it with @ondrejmirtes directly. I think we tried to get rid of the reqexp in |
|
This PR makes future maintenance of this locator easier but right now has worse performance. I have a plan to address this - we could make PHPStan faster because right now, the same work is done by all child processes which means it's done 8 times during each run. Instead, we could populate some cache in the main process before launching child processes, and those child processes could just read the cached data instead of doing all the work again. |
|
Rebased. |
|
This pull request has been marked as ready for review. |
| * @author Jordi Boggiano <j.boggiano@seld.be> | ||
| * @see https://github.com/composer/composer/pull/10107 | ||
| */ | ||
| class PhpFileCleaner |
There was a problem hiding this comment.
I remember seeing blackfire profiles where the PhpFileCleaner logic was on the hot path.
really like seeing this file beeing deleted :)
4 participants
No description provided.