Declare more PDOStatement method types #2096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Dec 12, 2022
stubs/PDOStatement.stub
Outdated
| @@ -7,5 +7,16 @@ | |||
| */ | |||
| class PDOStatement implements Traversable, IteratorAggregate | |||
| { | |||
| /** | |||
| * @template T | |||
stubs/PDOStatement.stub
Outdated
| * @param array<mixed> $ctorArgs | ||
| * @return false|T | ||
| */ | ||
| public function fetchObject($class = \stdclass::class, array $ctorArgs = array()) {} |
ondrejmirtes
approved these changes
Dec 13, 2022
|
Thank you! |
staabm
commented
Dec 13, 2022
| @@ -7,5 +7,16 @@ | |||
| */ | |||
| class PDOStatement implements Traversable, IteratorAggregate | |||
There was a problem hiding this comment.
would you agree adding a class-level generic for PDOStatement?
/**
* @template rowType
*
* @implements Traversable<int|string, rowType>
* @implements IteratorAggregate<int|string, rowType>
*
* @link https://php.net/manual/en/class.pdostatement.php
*/
I need the class to be generic for phpstan-dba to enrich this type with real-time db schema information.
There was a problem hiding this comment.
I have no idea how this class is used in practice in real-world code so I can't decide this :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types are part of phpstan-dba for a couple of releases, and therefore can be considered kind of battle tested