Prevent overly greedy $scope->getType() calls in ImpossibleInstanceOfRule #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
unnecessary-getType
branch
from
fe523bd to
d27aa06
Compare
staabm
force-pushed
the
unnecessary-getType
branch
from
8a9c1c9 to
27eefa8
Compare
|
FYI this could have been a single PR ;) It doesn't make much sense to open a bunch of related PRs at the same time:
Instead, open a single PR and wait for it to be merged. That way both of these problems are solved. And these are pretty simple PRs only with a few lines changed... |
|
Thank you. |
I thought it would be easier to review in smaller PRs.. but I am fine with a big one. fwiw, 1.9.3 vs. 1.9.x-dev has ~10.000 less getType() calls after these PRs :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs phpstan/phpstan#8146