Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor options handling in FilterVarDynamicReturnTypeExtension #2120

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Dec 16, 2022

It looks like I need a hasOptions(): TrinaryLogic for a bug fix which is how I ended up with this refactor. I could also get rid of a couple of instanceof ConstantArrayType and one instanceof ErrorType in the process. Most likely more similar expressions could be refactored, but this extension is a beast and I wanted to keep the changes small on purpose.

@herndlm herndlm force-pushed the refactor-options-in-filter-var-dynamic-return-type-extension branch from e91d994 to 5e33509 Compare December 16, 2022 13:11
@herndlm herndlm marked this pull request as draft December 16, 2022 13:13
@herndlm herndlm force-pushed the refactor-options-in-filter-var-dynamic-return-type-extension branch from 5e33509 to 938036d Compare December 16, 2022 13:14
@herndlm herndlm marked this pull request as ready for review December 16, 2022 13:20
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit a5b5090 into phpstan:1.9.x Dec 27, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@herndlm herndlm deleted the refactor-options-in-filter-var-dynamic-return-type-extension branch December 27, 2022 09:03
@herndlm
Copy link
Contributor Author

herndlm commented Dec 27, 2022

thx, hopefully I can finally do the actual bug fix now 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants