Refactor options handling in FilterVarDynamicReturnTypeExtension
#2120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like I need a
hasOptions(): TrinaryLogic
for a bug fix which is how I ended up with this refactor. I could also get rid of a couple ofinstanceof ConstantArrayType
and oneinstanceof ErrorType
in the process. Most likely more similar expressions could be refactored, but this extension is a beast and I wanted to keep the changes small on purpose.