Fix ReflectionClass::newInstanceArgs() - error on argument type
#2176
+55
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test it in CallMethodsRuleTest. |
|
FYI you based the PR on 1.10.x. This means it's going to be released somewhat later than if you based it on 1.9.x. Feel free to rebase it on top of 1.9.x, thanks. |
|
If you wish, merge this PR on |
|
You don't need to do a new PR, you can just change the base on 1.9.x and rebase on top of 1.9.x. Everything in 1.9.x gets merged automatically into 1.10.x. |
|
Now should be ok, next time I will start checking out a new dev branch and not working directly on official one. Less problem to do a rebase. Thaks for the support! |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ReflectionClass stub to solve phpstan/phpstan#8679.
Tests needed!