Make "required params following optional ones" ignorable #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Feb 3, 2023
|
Ah snap! I'll do it in the evening. Went to basketball game 😉 |
Such code is working as expected and PHPStan should not enforce changes there.
Wirone
force-pushed
the
codito/remove-php8-deprecation-error
branch
from
36b8216
to
fad43dd
Compare
Wirone
changed the title
|
@ondrejmirtes Should test be added for scenario with |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such code is working as expected and PHPStan should not enforce changes there.
Slack discussion, playground example.