Implement JsonValidateTypeSpecifyingExtension #2491
Conversation
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
| use PHPStan\Type\FunctionTypeSpecifyingExtension; | ||
| use function count; | ||
|
|
||
| class JsonValidateTypeSpecifyingExtension implements FunctionTypeSpecifyingExtension, TypeSpecifierAwareExtension |
There was a problem hiding this comment.
I tried using a stub signature instead, but this did not work for me locally:
/**
* @phpstan-assert-if-true non-falsy-string $json
* @return bool
*/
function json_validate(string $json, int $depth = 512, int $flags = 0): bool {}
as I can see this extension also only work in CI PHP 8.3.. I will retry using a stub signature on a different composer which has PHP 8.3 installed
There was a problem hiding this comment.
ok, did a few more tests. It does not work with pure stub signatures, because these would also affect the ELSE case in a wrong way:
1) PHPStan\Analyser\NodeScopeResolverTest::testFileAsserts with data set "/Users/staabm/workspace/phpstan-src/tests/PHPStan/Analyser/data/json_validate.php:13" ('type', '/Users/staabm/workspace/phpst...te.php', PHPStan\Type\Constant\ConstantStringType Object (...), PHPStan\Type\MixedType Object (...), 13)
Expected type mixed, got type mixed~non-falsy-string in /Users/staabm/workspace/phpstan-src/tests/PHPStan/Analyser/data/json_validate.php on line 13.
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'mixed'
+'mixed~non-falsy-string'
|
This pull request has been marked as ready for review. |
| */ | ||
| return [ | ||
| 'new' => [ | ||
| 'json_validate' => ['bool', 'json'=>'string', 'depth='=>'positive-int', 'flags='=>'int-mask<JSON_INVALID_UTF8_IGNORE>'], |
There was a problem hiding this comment.
only a single flag is supported, see php/php-src#9399 (comment)
| return new SpecifiedTypes([], []); | ||
| } | ||
|
|
||
| return $this->typeSpecifier->create($node->getArgs()[0]->value, new AccessoryNonFalsyStringType(), $context, false, $scope); |
There was a problem hiding this comment.
is non falsy string type correct here?
https://3v4l.org/5IGU2/rfc#vgit.master
'0' is a valid json string (according to php anyway) but is also falsey
There was a problem hiding this comment.
You are right. I did a 3v4l before with this exact case in mind. Seems I fucked it up.
Need to go with non-empty-string then :-)
|
Hi, I usually start preparing next PHP version support after feature freeze but I decided to make an exception here. Here's what I did:
|
|
thank you |
PHP8.3 Support for https://wiki.php.net/rfc/json_validate
this type-specifying extension narrows the
$jsonarg to a non-empty-string