report trait access to unititialized property in the trait instead of class #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlndh
force-pushed
the
fix-reportTraitAccessToUninitializedProperties
branch
from
fbf34b6 to
1095687
Compare
schlndh
force-pushed
the
fix-reportTraitAccessToUninitializedProperties
branch
from
1095687 to
342c75f
Compare
|
Nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in how access to uninitialized properties is reported. If the access is in a trait it was reported as being in the class, but the line number was from the trait, so it didn't make sense. This is an attempt to fix it so that the trait access gets reported similarly to other trait issues (i.e.
trait (in context of class)).