Some mysqli functions always return true

[kamil-tekiela]

php/doc-en@18d96d5

[phpstan-bot]

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

[ondrejmirtes]

PHPStan already knows this: https://phpstan.org/r/992b11b1-4192-459c-bb23-362f6a4e086e

[kamil-tekiela]

It doesn't seem it knows: https://phpstan.org/r/205aa72d-5f1f-476f-b6f0-6f748280140e
Maybe I made some mistake in my PR, but the demo here shows that it thinks the type is bool.

[ondrejmirtes]

That should be fixed in official stubs in php-src. PHPStan uses automatically extracted signatures and there it's still bool: https://github.com/phpstan/php-8-stubs/blob/main/stubs/ext/mysqli/mysqli_field_seek.php

In php-src: https://github.com/php/php-src/blob/17b3af29589ef5667c44dae7aaa11f1018e6949b/ext/mysqli/mysqli.stub.php#L1460

Compare that with mysqli_close: https://github.com/phpstan/php-8-stubs/blob/main/stubs/ext/mysqli/mysqli_close.php + https://github.com/php/php-src/blob/17b3af29589ef5667c44dae7aaa11f1018e6949b/ext/mysqli/mysqli.stub.php#L1592

[kamil-tekiela]

PR is waiting to be merged php/php-src#11948