Skip to content

Conversation

janedbal
Copy link
Contributor

No description provided.

@phpstan-bot
Copy link
Collaborator

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

@janedbal janedbal force-pushed the throw-type-conditional-tags branch from 2bef86b to 9a07840 Compare August 17, 2023 14:00
@janedbal janedbal changed the base branch from 1.11.x to 1.10.x August 17, 2023 14:00
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this list is complete yet.

Please search phpstan-src for * services:, you should get all the extensions that support registering via service tag in configurafion files. And add them to this list :) Thank you.

@janedbal
Copy link
Contributor Author

Added, hopefully I found all of them. Checked also _TAG = and 'phpstan. usages.

@janedbal janedbal changed the title ConditionalTagsExtension: add throw type extension tags ConditionalTagsExtension: add missing tags Aug 17, 2023
@janedbal janedbal requested a review from ondrejmirtes August 17, 2023 15:45
@ondrejmirtes ondrejmirtes merged commit 46607cc into phpstan:1.10.x Aug 17, 2023
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants