Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConditionalTagsExtension: add missing tags #2574

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

janedbal
Copy link
Contributor

No description provided.

@phpstan-bot
Copy link
Collaborator

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

@janedbal janedbal changed the base branch from 1.11.x to 1.10.x August 17, 2023 14:00
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this list is complete yet.

Please search phpstan-src for * services:, you should get all the extensions that support registering via service tag in configurafion files. And add them to this list :) Thank you.

@janedbal
Copy link
Contributor Author

Added, hopefully I found all of them. Checked also _TAG = and 'phpstan. usages.

@janedbal janedbal changed the title ConditionalTagsExtension: add throw type extension tags ConditionalTagsExtension: add missing tags Aug 17, 2023
@ondrejmirtes ondrejmirtes merged commit 46607cc into phpstan:1.10.x Aug 17, 2023
410 of 411 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants