Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support array shape covariance #2655

Merged
merged 2 commits into from Sep 30, 2023
Merged

Support array shape covariance #2655

merged 2 commits into from Sep 30, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Sep 29, 2023

@ondrejmirtes
Copy link
Member

Jackpot! Look at issue bot. This also fixes:

Please add regression tests. Thank you.

@staabm
Copy link
Contributor Author

staabm commented Sep 29, 2023

ha, didn't realize it… 🥳

@herndlm
Copy link
Contributor

herndlm commented Sep 29, 2023

Amazing. Looks like I also debugged around in those 2 issues and then the fix is a one-liner 🎉

@ondrejmirtes ondrejmirtes merged commit f57052d into phpstan:1.10.x Sep 30, 2023
414 of 417 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

This was referenced Sep 30, 2023
Closed
Closed
Closed
@staabm staabm deleted the bug9905 branch September 30, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@staabm @ondrejmirtes @herndlm