Skip to content

Respect proper case for namespaced functions #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Respect proper case for namespaced functions #2673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97f894b
Regression test
fredden Oct 10, 2023
0db2317
Use real native function name instead of lowercase one
ondrejmirtes Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Reflection/SignatureMap/NativeFunctionReflectionProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public function __construct(private SignatureMapProvider $signatureMapProvider,
public function findFunctionReflection(string $functionName): ?NativeFunctionReflection
{
$lowerCasedFunctionName = strtolower($functionName);
$realFunctionName = $lowerCasedFunctionName;
if (isset($this->functionMap[$lowerCasedFunctionName])) {
return $this->functionMap[$lowerCasedFunctionName];
}
Expand All @@ -54,6 +55,7 @@ public function findFunctionReflection(string $functionName): ?NativeFunctionRef
$reflectionFunction = $this->reflector->reflectFunction($functionName);
$reflectionFunctionAdapter = new ReflectionFunction($reflectionFunction);
$returnsByReference = TrinaryLogic::createFromBoolean($reflectionFunctionAdapter->returnsReference());
$realFunctionName = $reflectionFunction->getName();
if ($reflectionFunction->getFileName() !== null) {
$fileName = $reflectionFunction->getFileName();
$docComment = $reflectionFunction->getDocComment();
Expand Down Expand Up @@ -127,7 +129,7 @@ public function findFunctionReflection(string $functionName): ?NativeFunctionRef
}

$functionReflection = new NativeFunctionReflection(
$lowerCasedFunctionName,
$realFunctionName,
$variants,
$throwType,
$hasSideEffects,
Expand Down
14 changes: 14 additions & 0 deletions tests/PHPStan/Rules/Functions/CallToNonExistentFunctionRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,4 +244,18 @@ public function testBug8205(): void
$this->analyse([__DIR__ . '/data/bug-8205.php'], []);
}

public function testBug10003(): void
{
$this->analyse([__DIR__ . '/data/bug-10003.php'], [
[
'Call to function MongoDB\Driver\Monitoring\addSubscriber() with incorrect case: MONGODB\Driver\Monitoring\addSubscriber',
10,
],
[
'Call to function MongoDB\Driver\Monitoring\addSubscriber() with incorrect case: mongodb\driver\monitoring\addsubscriber',
14,
],
]);
}

}
16 changes: 16 additions & 0 deletions tests/PHPStan/Rules/Functions/data/bug-10003.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php declare(strict_types = 1);

namespace Bug10003;

class HelloWorld
{
public function check(\MongoDB\Driver\Monitoring\Subscriber $a): void
{
// Wrong.
\MONGODB\Driver\Monitoring\addSubscriber($a);
// Correct.
\MongoDB\Driver\Monitoring\addSubscriber($a);
// Wrong.
\mongodb\driver\monitoring\addsubscriber($a);
}
}