Optimize memory consumption #2680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Oct 14, 2023
| @@ -42,12 +40,11 @@ public function createByDirectory(string $directory): NewOptimizedDirectorySourc | |||
| $files = $this->fileFinder->findFiles([$directory])->getFiles(); | |||
| $fileHashes = []; | |||
| foreach ($files as $file) { | |||
| try { | |||
| $contents = FileReader::read($file); | |||
There was a problem hiding this comment.
I think there are more places that do the same thing, please check ResultCacheManager. Or all the places that use FileReader. Thanks.
staabm
commented
Oct 14, 2023
| @@ -789,10 +789,7 @@ private function getFileHash(string $path): string | |||
| return $this->fileHashes[$path]; | |||
| } | |||
|
|
|||
| $contents = FileReader::read($path); | |||
| $contents = str_replace("\r\n", "\n", $contents); | |||
There was a problem hiding this comment.
here was some normalization going on. removing it did not break tests.
I assume the result cache is not meant to be shared across different computers, therefore it seems not necessary
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested with
blackfire run --ignore-exit-status php vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.phpbefore this PR: (1.10.x@7c4ef6b2a)
after this PR: