ArrayFilterFunctionReturnTypeReturnTypeExtension handle error types #2794
Conversation
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
| @@ -54,9 +55,13 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection, | |||
| } | |||
|
|
|||
| $arrayArgType = $scope->getType($arrayArg); | |||
| $arrayArgType->isArray(); | |||
There was a problem hiding this comment.
The right solution is:
$arrays = TypeUtils::toBenevolentUnion($arrayArgType)->getArrays();
$arrayArgType = TypeCombinator::union(...$arrays);There was a problem hiding this comment.
Ah, whoops that was a debugging line I thought I had deleted. Thanks for the direction, I will try it out.
There was a problem hiding this comment.
Or maybe just would work too:
$arrayArgType = TypeUtils::toBenevolentUnion($arrayArgType);There was a problem hiding this comment.
And please listen to the bot 😊 #2794 (comment)
There was a problem hiding this comment.
I'll rebase off of 1.10.x and change the PR, I was waiting for "this is a horrible wrong approach" or not. Rebasing now
There was a problem hiding this comment.
Okay, rebased off of 1.10.x and changed the PR base
mglaman
force-pushed
the
array-filter-on-invalid-union
branch
from
0e0a367
to
cf5484c
Compare
|
Thank you! |
|
Thanks for the guidance along the way! |
|
Fixed also phpstan/phpstan#8638, thank you! |
Fixes phpstan/phpstan#10189