Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require-extends should not error on interfaces #2861

Merged
merged 6 commits into from Jan 10, 2024
Merged

require-extends should not error on interfaces #2861

merged 6 commits into from Jan 10, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jan 10, 2024 •
edited

There are two issues:

  1. Interface should not complain about not extending a class
  2. When the interface is being implemented by the class required, the rule should not complain

Both are reproduced here:
https://phpstan.org/r/25925129-a872-4300-8437-a8edd6dc825a

@staabm staabm marked this pull request as ready for review January 10, 2024 16:25
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit 98a1037 into phpstan:1.10.x Jan 10, 2024
423 of 426 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the extended-interface branch January 10, 2024 23:50
@staabm staabm mentioned this pull request Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@staabm @phpstan-bot @ondrejmirtes