Add composer-dependency-analyser to CI (fix shadow & misplaced dependencies)

.github/workflows/lint.yml

@@ -103,8 +103,8 @@ jobs:
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
-      - name: "Composer Require Checker"
-        run: "make composer-require-checker"
+      - name: "Composer Dependency Analyser"
+        run: "make composer-dependency-analyser"
 
   name-collision:
     name: "Name Collision Detector"

Makefile

@@ -94,8 +94,8 @@ phpstan-generate-baseline-php:
 phpstan-pro:
 	php -d memory_limit=448M bin/phpstan --pro
 
-composer-require-checker:
-	php build/composer-require-checker.phar check --config-file $(CURDIR)/build/composer-require-checker.json
-
 name-collision:
 	php vendor/bin/detect-collisions --configuration build/collision-detector.json
+
+composer-dependency-analyser:
+	php vendor/bin/composer-dependency-analyser --config build/composer-dependency-analyser.php

build/composer-dependency-analyser.php

@@ -0,0 +1,17 @@
+<?php declare(strict_types = 1);
+
+use ShipMonk\ComposerDependencyAnalyser\Config\Configuration;
+use ShipMonk\ComposerDependencyAnalyser\Config\ErrorType;
+
+$config = new Configuration();
+
+return $config
+	->addPathToScan(__DIR__ . '/../bin', true)
+	->ignoreErrors([ErrorType::UNUSED_DEPENDENCY])
+	->ignoreErrorsOnPackage('phpunit/phpunit', [ErrorType::DEV_DEPENDENCY_IN_PROD]) // prepared test tooling
+	->ignoreErrorsOnPackage('jetbrains/phpstorm-stubs', [ErrorType::PROD_DEPENDENCY_ONLY_IN_DEV]) // there is no direct usage, but we need newer version then required by ondrejmirtes/BetterReflection
+	->ignoreErrorsOnPath(__DIR__ . '/../tests', [ErrorType::UNKNOWN_CLASS]) // to be able to test invalid symbols
+	->ignoreUnknownClasses([
+		'JetBrains\PhpStorm\Pure', // not present on composer's classmap
+		'PHPStan\ExtensionInstaller\GeneratedConfig', // generated
+	]);

composer.json

@@ -13,11 +13,11 @@
 		"fidry/cpu-core-counter": "^0.5.0",
 		"hoa/compiler": "3.17.08.08",
 		"hoa/exception": "^1.0",
+		"hoa/file": "1.17.07.11",
 		"hoa/regex": "1.17.01.13",
 		"jetbrains/phpstorm-stubs": "dev-master#717e2d512b1525a604d98b7799d0d6839448ee07",
 		"nette/bootstrap": "^3.0",
 		"nette/di": "3.1.10",
-		"nette/finder": "^2.5",
 		"nette/neon": "^3.3.1",
 		"nette/schema": "^1.2.2",
 		"nette/utils": "^3.2.5",
@@ -26,6 +26,7 @@
 		"ondrejmirtes/better-reflection": "6.21.0",
 		"phpstan/php-8-stubs": "0.3.84",
 		"phpstan/phpdoc-parser": "1.25.0",
+		"psr/http-message": "^1.1",
 		"react/async": "^3",
 		"react/child-process": "^0.6.4",
 		"react/dns": "^1.10",
@@ -53,13 +54,15 @@
 	"require-dev": {
 		"brianium/paratest": "^6.5",
 		"cweagans/composer-patches": "^1.7.3",
+		"nette/finder": "^2.5",
 		"ondrejmirtes/simple-downgrader": "^1.0",
 		"php-parallel-lint/php-parallel-lint": "^1.2.0",
 		"phpstan/phpstan-deprecation-rules": "^1.0",
 		"phpstan/phpstan-nette": "^1.0",
 		"phpstan/phpstan-phpunit": "^1.0",
 		"phpstan/phpstan-strict-rules": "^1.5.1",
 		"phpunit/phpunit": "^9.5.4",
+		"shipmonk/composer-dependency-analyser": "^1.0",
 		"shipmonk/name-collision-detector": "^2.0"
 	},
 	"config": {