Improve parameter type of SplObjectStorage::removeAll/Except #2892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
force-pushed
the
fix-SplObjectStorageRemove
branch
from
0c34325 to
af13ca6
Compare
|
Nice, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://phpstan.org/r/bff03687-1f39-496b-a23e-0386bcb75362 . Ideally,
removeNoIntersectshould be reported as an issue since it is not possible for the removes to do anything. However, AFAIK there is no way to express such constraint in the current type system (i.e. I'd want to make sure that the key types of the two storages have a non-empty intersection).I considered using
\SplObjectStorage<covariant TObject, *>|\SplObjectStorage<contravariant TObject, *>, which would reportremoveNoIntersect, but it would lead to a false positive inremovePossibleIntersect. And\SplObjectStorage<*, *>seems to have been the intention of the previous stub.Fixes phpstan/phpstan#9411