Add rule to check for existing classes, type aliases and shadowing of CallableType and ClosureType templates on methods and functions. #2945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mad-briller
commented
Feb 26, 2024
mad-briller
commented
Feb 26, 2024
mad-briller
force-pushed
the
genericcallables-rules
branch
from
afb2253 to
55ec3cd
Compare
ondrejmirtes
requested changes
Feb 26, 2024
mad-briller
force-pushed
the
genericcallables-rules
branch
2 times, most recently
from
07f70fa to
8d13946
Compare
ondrejmirtes
requested changes
Feb 26, 2024
mad-briller
force-pushed
the
genericcallables-rules
branch
2 times, most recently
from
f37db3b to
82bff62
Compare
… CallableType and ClosureType templates on methods and functions.
mad-briller
force-pushed
the
genericcallables-rules
branch
from
82bff62 to
a6cdbfe
Compare
|
Perfect, thank you! Looking forward to next steps :) |
Already got native properties covered just need to rebase when I'm at home |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to: #2938 (review)
covers
@param@param-outand@returnon functions / methods