Skip to content

Add rule to check for existing classes, type aliases and shadowing of generic callables in properties. #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mad-briller
Copy link
Contributor

another follow up to: #2938 (review)

covers native properties

@mad-briller mad-briller force-pushed the genericcallables-properties branch from 24da3c3 to 10a6d28 Compare February 27, 2024 21:46
@mad-briller
Copy link
Contributor Author

mad-briller commented Feb 27, 2024

is there a way to disable the Lint action for a file on a specific php version or do i have to exclude it for all / make the test file compatible with all?

@mad-briller mad-briller force-pushed the genericcallables-properties branch from 10a6d28 to 7ec12df Compare February 27, 2024 21:50
@mad-briller mad-briller force-pushed the genericcallables-properties branch 2 times, most recently from 9c8bff7 to 5f9468b Compare February 27, 2024 22:08
@mad-briller mad-briller force-pushed the genericcallables-properties branch from 5f9468b to 0226579 Compare February 27, 2024 22:11
@ondrejmirtes ondrejmirtes merged commit 810133d into phpstan:1.10.x Mar 5, 2024
@ondrejmirtes
Copy link
Member

Thank you!

@mad-briller
Copy link
Contributor Author

Currently without a dev env to continue on with the other steps, I'll try to follow up when I get one sorted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants