Skip to content

TypeNodeResolver: variadics are always optional #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2020
Merged

TypeNodeResolver: variadics are always optional #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ec22a1
TypeNodeResolver: variadics are always optional
dktapps Aug 31, 2020
7b90f19
added test case for phpstan/phpstan#3798
dktapps Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PhpDoc/TypeNodeResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ function (CallableTypeParameterNode $parameterNode) use ($nameScope, &$isVariadi
$isVariadic = $isVariadic || $parameterNode->isVariadic;
return new NativeParameterReflection(
$parameterNode->parameterName,
$parameterNode->isOptional,
$parameterNode->isOptional || $parameterNode->isVariadic,
$this->resolve($parameterNode->type, $nameScope),
$parameterNode->isReference ? PassedByReference::createCreatesNewVariable() : PassedByReference::createNo(),
$parameterNode->isVariadic,
Expand Down
6 changes: 6 additions & 0 deletions tests/PHPStan/Analyser/AnalyserIntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,12 @@ public function testBug3379(): void
$this->assertSame('Reflection error: Could not locate constant "SOME_UNKNOWN_CONST" while evaluating expression in Bug3379\Foo at line 8', $errors[1]->getMessage());
}

public function testBug3798(): void
{
$errors = $this->runAnalyse(__DIR__ . '/data/bug-3798.php');
$this->assertCount(0, $errors);
}

/**
* @param string $file
* @return \PHPStan\Analyser\Error[]
Expand Down
10 changes: 10 additions & 0 deletions tests/PHPStan/Analyser/data/bug-3798.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php declare(strict_types = 1);

namespace Bug3798;

/** @param callable(int ...$params) : void $c */
function acceptsVariadicCallable(callable $c) : void{
$c();
$c(1);
$c(1, 2, 3);
}