More precise sprintf() format-arg based return type #3192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jun 28, 2024
staabm
commented
Jun 28, 2024
| @@ -107,13 +107,17 @@ function stringFunctions(string $s, $nonFalsey, $arrayOfNonFalsey, $nonEmptyArra | |||
| assertType('string', sprintf($nonFalsey)); | |||
| assertType("'foo'", sprintf('foo')); | |||
| assertType("string", sprintf(...$arr)); | |||
| assertType("non-falsy-string", sprintf('%s', ...$arr)); // should be 'string' | |||
There was a problem hiding this comment.
fixes previous too specific types
|
I think the remaining error is a bug: phpstan/phpstan#11249 |
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
sprintf4
branch
4 times, most recently
from
056c194 to
ce1c5c2
Compare
ondrejmirtes
requested changes
Jul 12, 2024
|
sorry for all these commits to make it finally build on php 7.2 without errors. |
|
Thank you! |
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #3168
closes phpstan/phpstan#11248
closes phpstan/phpstan#10493
the previous format-type based logic was too optimistic regarding types and false-positively created too precise types in some cases.