Infer private properties in constructor, even if typehinted

[Baldinof]

Hi!

When using the flag inferPrivatePropertyTypeFromConstructor: true, the inference is disabled if the property is natively typehinted.

However the inference could provide a more specific type (eg: generic).

A usecase is ORM:

class UserRepository
{
    private DatabaseClient $db;

    public function __construct(DatabaseClientProvider $dbClientProvider)
    {
        $this->db = $dbClientProvider->for(User::class);
    }

    public function get(string $id): User
    {
         return $this->db->query('...');
    }
}

This PR allows PHPStan to infer DatabaseClient<User> instead of just DatabaseClient for the $db property.

[Baldinof]

Hi @ondrejmirtes, as this PR started as a draft, I don't know if you received a notification when I marked it as ready for review, so I am just raising a hand in case :)

[ondrejmirtes]

The more modern way of testing such stuff is done in NodeScopeResolverTest::testFileAsserts(), please rework your tests based on that.

[ondrejmirtes]

I'm missing a test scenario here - the property has native type int, the constructor assigns type string. I'm interested in what type the final property has - should be int.

[Baldinof]

Nice catch, I added some cases, it seems TypehintHelper is doing a very good job.

Do you see other scenario where it could misbehave?

[ondrejmirtes]

Thank you!

[Baldinof]

Thank you for building and maintaining this awesome project :)

[ondrejmirtes]

I'm sorry, I had to revert this. It led to some undesired behaviour that's hard to avoid (while keeping the rest of the functionality): phpstan/phpstan#4234

[Baldinof]

No problem, sorry for the troubles :(

[snapshotpl]

Damn, that was great feature to reduce phpdocs. @ondrejmirtes do you have a plan to bring it back with fixes?

[ondrejmirtes]

@snapshotpl It still works when the property doesn't have a native typehint. I don't plan to bring it back when the property has a native typehint, the need for PHPDocs is reduced greatly in that case, and the feature led to some false positives...