Improve specified type in comparisons #390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR has a side-effect that might need to be addressed, consider this code:
The change in output is as follows:
While technically correct, this is not very pretty.
Perhaps this can be fixed by adjusting how
IntegerRangeType
is represented. Currently,int<0, max>
(return value ofcount()
) is internally represented bymin=0, max=PHP_INT_MAX
, which is technically a bounded interval. If it were to usemin=0, max=null
instead, then the intended meaning of an open interval can be represented more accurately and the new code in this PR could make use of that information. If this sounds good I'll have a go at it.