Skip to content

DeprecationExtensions: allow custom deprecation-marking logic #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 14, 2025
Merged

DeprecationExtensions: allow custom deprecation-marking logic #3932

merged 15 commits into from
Apr 14, 2025

Conversation

janedbal
Copy link
Contributor

@janedbal janedbal mentioned this pull request Apr 11, 2025
Closed
ondrejmirtes
ondrejmirtes requested changes Apr 12, 2025
View reviewed changes
@janedbal janedbal changed the title DeprecationProviders: allow custom deprecation-marking logic DeprecationExtensions: allow custom deprecation-marking logic Apr 14, 2025
@janedbal janedbal requested a review from ondrejmirtes April 14, 2025 07:38
ondrejmirtes
ondrejmirtes requested changes Apr 14, 2025
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeprecationProvider $deprecationResolver is in a bunch of places. So is it provider or resolver? 😊 Please sync the type and the parameter name.

ondrejmirtes
ondrejmirtes requested changes Apr 14, 2025
View reviewed changes
@janedbal janedbal requested a review from ondrejmirtes April 14, 2025 10:37
This was referenced Apr 14, 2025
Merged
Merged
@ondrejmirtes ondrejmirtes merged commit 752d229 into phpstan:2.1.x Apr 14, 2025
416 of 417 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@ondrejmirtes ondrejmirtes mentioned this pull request Apr 16, 2025
Closed
@herndlm herndlm mentioned this pull request Apr 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes Awaiting requested review from ondrejmirtes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janedbal @ondrejmirtes