Fix forgetting static property access after impure call #3950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
staabm
commented
Apr 19, 2025
staabm
commented
Apr 19, 2025
ondrejmirtes
requested changes
Apr 19, 2025
ondrejmirtes
requested changes
Apr 19, 2025
staabm
commented
Apr 20, 2025
Comment on lines
+2601
to
+2602
| $parametersAcceptor instanceof ClosureType && count($parametersAcceptor->getImpurePoints()) > 0 | ||
| && $scope->isInClass() |
There was a problem hiding this comment.
last open question: do we want to invalidate 'this' in this case for regular function calls with side-effects?
we only handle Closure at this point right now
see #3950 (comment)
There was a problem hiding this comment.
Scratch that. A function is pretty unlikely to affect $this or self
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#11019
closes phpstan/phpstan#3747
closes phpstan/phpstan#8523
closes phpstan/phpstan#4864
fixes one repro of phpstan/phpstan#8926
closes phpstan/phpstan#4443