Make IntegerRangeType represent open intervals properly #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the usage of
PHP_INT_MIN
andPHP_INT_MAX
to mark open-ended intervals and instead usesnull
for that purpose. Since usinggetMin()
andgetMax()
now became slightly more complicated for callers, a lot ofIntegerRangeType
-related logic has been moved into the class itself.I especially like that some type combinator logic is now inside the type class, but without too much pressure, since it is allowed to return
null
when it can't handle the situation. Perhaps this could be extended into the entireType
hierarchy.