Fix ocdb function signatures #4119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Jul 21, 2025
There was a problem hiding this comment.
Please do not update the parameter names. PHPStan already knows the correct ones thanks to https://github.com/phpstan/php-8-stubs. The only thing your change would do would be breaking baselines for people on PHP 7.x.
I simplified the PR |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every function returning a ressource can return false
Currently there is an inconsistent behavior https://phpstan.org/r/6ef0920a-7e33-4c93-a08c-82a76e6a7557
(In php 8.4 it returns ressource|false but in lower php version it returns false.)
odbc_dowas forgotten in the functionMap_delta since it's an alias ofodbc_exec