Check for identifiers before identifier #4143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Jul 22, 2025
VincentLanglet
force-pushed
the
identifiers
branch
from
740cb3c to
fc0dc5a
Compare
ondrejmirtes
requested changes
Sep 7, 2025
There was a problem hiding this comment.
On a 2nd look, I don't get it. An entry with both identifier and identifiers should be considered invalid.
I'm arguing in #4111 we should move the ever-exploding parameters schema validation of ignoreErrors to an actual imperative code in ContainerFactory.
Could you look at it instead? Thank you.
|
Closing in favor of #4309 (I think) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.