Detect more possibly-impossible offset #4164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like the error could always be reported on level 7+. The difference is that the |
VincentLanglet
changed the title
VincentLanglet
force-pushed
the
test/1061
branch
from
35af5a4 to
f4b6dbd
Compare
VincentLanglet
force-pushed
the
test/1061
branch
10 times, most recently
from
c290ea1 to
2417411
Compare
|
This pull request has been marked as ready for review. |
VincentLanglet
force-pushed
the
test/1061
branch
from
2417411 to
0a8a1e2
Compare
ondrejmirtes
requested changes
Aug 5, 2025
VincentLanglet
force-pushed
the
test/1061
branch
from
0a8a1e2 to
accabee
Compare
ondrejmirtes
requested changes
Aug 30, 2025
| { | ||
| "message": "Possibly invalid array key type int|object.", | ||
| "line": 35, | ||
| "ignorable": true | ||
| }, | ||
| { | ||
| "message": "Offset int|object might not exist on array{baz: 21}|array{foo: 17, bar: 19}.", |
There was a problem hiding this comment.
This looks wrong for array{foo: 17, bar: 19}|array{baz: 21}. int|object never exists on these arrays.
There was a problem hiding this comment.
Indeed, I think this is because of #4272 which need to be fix/merged first then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#1061