Add array_rand return type extension #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
arrayRand
branch
from
c252c46 to
eafd1eb
Compare
VincentLanglet
force-pushed
the
arrayRand
branch
4 times, most recently
from
aaa7dd6 to
9eefa76
Compare
|
I don't understand the failure @ondrejmirtes |
BackEndTea
reviewed
Jan 7, 2021
There was a problem hiding this comment.
Maybe i'm misunderstanding something here, but array_rand returns a random key right?
So the return type here would a int, as this array is a list:
https://3v4l.org/H1hqZ
BackEndTea
reviewed
Jan 7, 2021
There was a problem hiding this comment.
Prehaps this could also check if the value is bigger than the array size: https://3v4l.org/LYSTs
There was a problem hiding this comment.
And how do you get the size of the array ?
VincentLanglet
force-pushed
the
arrayRand
branch
from
9eefa76 to
1b31d34
Compare
VincentLanglet
force-pushed
the
arrayRand
branch
from
1b31d34 to
4d0bfb4
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.