Skip to content

Remove couchbase from functionmap #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Jul 28, 2025

This would
Closes phpstan/phpstan#5642

Maybe I didn't fully understood the gain of having those method in the functionMap but

  • the current functionMap documents the outdated couchbase version 2.
  • phpstorm-stubs correctly documents the couchbase version 3.
  • there is a lot of difference between the two version (class/function removed, class/function added, lot of signature changed)

As a proof I get the correct error in my non regression test.

@VincentLanglet VincentLanglet marked this pull request as ready for review July 28, 2025 18:29
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes
Copy link
Member

Thank you!

This might be an idea for a project: remove huge chunks of functionMap for things that are already nicely covered by phpstorm-stubs.

We can't remove signatures that use special PHPStan types like non-empty-string or benevolent union, but I still think we can make it much smaller. Feel free to send PRs that remove one extension at a time.

@ondrejmirtes ondrejmirtes merged commit 985c791 into phpstan:2.1.x Jul 29, 2025
415 of 421 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couchbase and Couchbase_v3 mismatching issue
3 participants