Skip to content

Fix session_set_cookie_params signature #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2025
Merged

Fix session_set_cookie_params signature #4194

merged 2 commits into from
Sep 2, 2025

Conversation

VincentLanglet
Copy link
Contributor

Closes phpstan/phpstan#7772

From the changelog of https://www.php.net/manual/en/function.session-set-cookie-params.php

8.0.0 | path, domain, secure and httponly are nullable now.

@VincentLanglet VincentLanglet force-pushed the fix/7772 branch 2 times, most recently from cb437f5 to 619f2d8 Compare August 30, 2025 10:17
@ondrejmirtes ondrejmirtes merged commit c1175bd into phpstan:2.1.x Sep 2, 2025
449 of 454 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibly wrong type check for nullable parameters in function session_set_cookie_params
2 participants
@VincentLanglet @ondrejmirtes