Escape tag in githubErrorFormatter #4198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Aug 2, 2025
| @@ -84,7 +84,7 @@ public static function dataFormatterOutputProvider(): iterable | |||
| yield [ | |||
| 'message' => 'One file error with tip', | |||
| 'exitCode' => 1, | |||
| 'numFileErrors' => [5, 6], | |||
There was a problem hiding this comment.
This was wrong, this is supposed to be
- The offset (5)
- The length (1), not 6
This is not a list of the offset to take.
VincentLanglet
force-pushed
the
escapeTagGithubErrorFormatter
branch
from
f98f705 to
96d1f29
Compare
|
Please do the same in issue-bot/ that posts comments. Assuming we can also do this in plain Markdown, not just in GitHub Actions. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#10051