Treat Redis::connect as non-deterministic

[vrana]

Fixes https://phpstan.org/r/1695567f-4869-428f-8cb6-fdd8cb147be1.

[ondrejmirtes]

1. I'd say connect method has to change instead, that will take care of invalidating remembered isConnected when called.
2. You edited the correct file but you also need to run bin/ script to regenerate the metadats file that doesn't have "original" in its name.

If you're interested, you can check out this part of my talk about pure/impure and so on here: https://youtu.be/AFjr3RlDOZQ?si=dp_XJWfenGJBRQhp (from about 28:50 timestamp)

[vrana]

Makes sense. Please suggest how can I test this.

[staabm]

you can add a new testXX method into tests/PHPStan/Rules/TooWideTypehints/TooWidePropertyTypeRuleTest.php
and put your code from https://phpstan.org/r/1695567f-4869-428f-8cb6-fdd8cb147be1 into the tests data/ directory.

then assert no errors

similar to

phpstan-src/tests/PHPStan/Rules/TooWideTypehints/TooWidePropertyTypeRuleTest.php

Lines 104 to 107 in 99efae3

	public function testBug13384bOff(): void
	{
	$this->analyse([__DIR__ . '/data/bug-13384b.php'], []);
	}

[vrana]

I've added the test but I couldn't reproduce the original behavior before this change.

[staabm]

Needs $this->reportTooWideBool = true; in the rule test class

[vrana]

Thanks, hallelujah!

[staabm]

don't get confused by the CI results.. we currently investigate spurious CI errors

[ondrejmirtes]

Thank you!