Skip to content

Improve idate() return types #4321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

Improve idate() return types #4321

merged 1 commit into from
Sep 15, 2025

Conversation

vrana
Copy link
Contributor

@vrana vrana commented Sep 11, 2025 •
edited
Loading

My first implementation also modified DateFunctionReturnTypeHelper to call IdateFunctionReturnTypeHelper but it was quite messy and it wasn't obvious what's coming from where.

staabm
staabm reviewed Sep 11, 2025
View reviewed changes
staabm
staabm reviewed Sep 11, 2025
View reviewed changes
ondrejmirtes
ondrejmirtes requested changes Sep 12, 2025
View reviewed changes
@ondrejmirtes ondrejmirtes merged commit fc35414 into phpstan:2.1.x Sep 15, 2025
444 of 456 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@claudepache claudepache mentioned this pull request Sep 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

+1 more reviewer

@staabm staabm staabm left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrana @ondrejmirtes @staabm