Skip to content

Conversation

miken32
Copy link
Contributor

@miken32 miken32 commented Sep 12, 2025

Per documentation, the crypto index is added for tls://, https://, and ftps:// streams. Indices of this array aren't documented, but they're in the source

crypto index is added for tls://, https://, and ftps:// streams
@ondrejmirtes ondrejmirtes merged commit dd63236 into phpstan:2.1.x Sep 13, 2025
446 of 457 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@miken32
Copy link
Contributor Author

miken32 commented Sep 17, 2025

You're welcome! I'm still having problems though. It seems like this signature is being ignored; the previous changes from 29c440e are also not showing. https://phpstan.org/r/5dd5aaef-80d2-47f1-bede-2956396ebc0b

@miken32
Copy link
Contributor Author

miken32 commented Sep 18, 2025

Ok just found this: https://github.com/phpstan/phpstan-src/blob/2.1.x/resources/functionMap_php83delta.php

It seems to be overriding the definitions for some reason; the commit message for 885d46b says uri is always there in 8.3, but it's not.

And I'm not sure what version it was, but this crypto key was added in php/php-src@676a505 as a result of conversation at php/php-src#1038 (comment) over ten years ago, so in PHP 5.6 days. I think it was only documented years later though.

So I think that entry in functionMap_php83delta.php can just be removed and that will resolve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants