Fix tests

[ondrejmirtes]

Closes phpstan/phpstan#13494

[staabm]

as the code stands it looks like PhpVersionStaticAccessor::registerInstance() might be called without also calling ReflectionProviderStaticAccessor::registerInstance, which might mean PhpVersionStaticAccessor::registerInstance() should also clear the cache

[ondrejmirtes]

I'm doing ObjectType::resetCaches only in ReflectionProvider accessor because that's what it depends on. I don't think there's any cache depending on PhpVersionStaticAccessor?

[staabm]

nice!

[ondrejmirtes]

You were right about the PhpVersion, I just saw a failure that could be explained by that:

1) PHPStan\Type\Generic\GenericObjectTypeTest::testIsSuperTypeOf with data set #2 (PHPStan\Type\Generic\GenericObjectType Object (...), PHPStan\Type\Generic\GenericObjectType Object (...), PHPStan\TrinaryLogic Object (...))
ReflectionClass<object> -> isSuperTypeOf(ReflectionClass<stdClass>)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'No'
+'Yes'

/Users/ondrej/Development/phpstan/tests/PHPStan/Type/Generic/GenericObjectTypeTest.php:270

2) PHPStan\Type\Generic\GenericObjectTypeTest::testIsSuperTypeOf with data set #3 (PHPStan\Type\Generic\GenericObjectType Object (...), PHPStan\Type\Generic\GenericObjectType Object (...), PHPStan\TrinaryLogic Object (...))
ReflectionClass<stdClass> -> isSuperTypeOf(ReflectionClass<object>)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'No'
+'Maybe'

Gonna reset the caches in any case. Thanks!

[VincentLanglet]

Awesome !