Skip to content

Fix XDOMPath::query() return type #4373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

Fix XDOMPath::query() return type #4373

merged 1 commit into from
Oct 6, 2025

Conversation

stefanfisk
Copy link
Contributor

@stefanfisk
Copy link
Contributor Author

Removing the stub for DOMXPath fixes the issue and all tests pass. But I don't understand if there are any other consequences to this approach compared to providing a fully typed stub.

@ondrejmirtes ondrejmirtes merged commit 97289f1 into phpstan:2.1.x Oct 6, 2025
544 of 549 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect return type for DOMXPath::query()

2 participants

@stefanfisk @ondrejmirtes