Skip to content

Simplify ClassReflectionExtensions #4374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2025
+2 −2
Merged

Simplify ClassReflectionExtensions #4374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Reflection/Annotations/AnnotationsMethodsClassReflectionExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function hasMethod(ClassReflection $classReflection, string $methodName):
$this->methods[$classReflection->getCacheKey()][$methodName] = $method;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case this property is meant to be a cache, I think we could adjust the above IF case, as it effectively means a non-existant method will be checked for over and over again

}

return isset($this->methods[$classReflection->getCacheKey()][$methodName]);
return true;
}

public function getMethod(ClassReflection $classReflection, string $methodName): ExtendedMethodReflection
Expand Down
2 changes: 1 addition & 1 deletion src/Reflection/Annotations/AnnotationsPropertiesClassReflectionExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function hasProperty(ClassReflection $classReflection, string $propertyNa
$this->properties[$classReflection->getCacheKey()][$propertyName] = $property;
}

return isset($this->properties[$classReflection->getCacheKey()][$propertyName]);
return true;
}

public function getProperty(ClassReflection $classReflection, string $propertyName): ExtendedPropertyReflection
Expand Down
Loading