Fix "array_rand() - offset might not exists"

[staabm]

closes phpstan/phpstan#12981

when merging, we should extract phpstan/phpstan#12981 (comment) into a new issue

[phpstan-bot]

This pull request has been marked as ready for review.

[VincentLanglet]

I feel like a good improvement would be to not have this error reported because it's already reported as a Invalid array key type.

https://phpstan.org/r/b4c81787-7c0b-46b3-b281-dd572ab6f8ac

But that's another issue, I'll a look at it.

[VincentLanglet]

WIP #4385

[VincentLanglet]

I think that if you rebase your PR @staabm your tests won't give the same output

[VincentLanglet]

For the record, the fact

Offset array<int, int|string> might not exist on non-empty-array<bool|float|int|string>

is not reported anymore is expected.

The offset is already reported by the InvalidKey rule.

[staabm]

For the record, the fact

Offset array<int, int|string> might not exist on non-empty-array<bool|float|int|string>

thanks

The offset is already reported by the InvalidKey rule.

I just put the test-cases additionally into InvalidKeyInArrayDimFetchRuleTest so we can see the overall picture.

error on line 39 und 41 still overlap, maybe thats something which can also be improved in a separate PR

[VincentLanglet]

error on line 39 und 41 still overlap, maybe thats something which can also be improved in a separate PR

There are not fully overlapping.

• Possibly invalid array key type array<int, int|string>|int|string. is about the invalid array key array<int, int|string>
• Offset array<int, int|string>|int|string might not exist on non-empty-array<bool|float|int|string>. is about the fact that int|string might not exist on non-empty-array<bool|float|int|string> because you enabled reportPossiblyNonexistentGeneralArrayOffset. I assume this error disappear with reportPossiblyNonexistentGeneralArrayOffset = false.

[ondrejmirtes]

Thank you.