array_rand() requires a non-empty-array as of php8 #4397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it even requires a positve $num arg as of php8, see https://3v4l.org/b53OZ |
staabm
commented
Oct 2, 2025
| 'iterator_count' => ['0|positive-int', 'iterator'=>'iterable'], | ||
| 'iterator_to_array' => ['array', 'iterator'=>'iterable', 'use_keys='=>'bool'], | ||
| 'str_split' => ['list<string>', 'str'=>'string', 'split_length='=>'positive-int'], | ||
| 'Random\Randomizer::pickArrayKeys' => ['non-empty-array<int|string>', 'array'=>'non-empty-array', 'num'=>'positive-int'], |
There was a problem hiding this comment.
not sure whether/how this signature should be behind bleeding edge but beeing php 8.2+ at the same time.
as the api is pretty recent and throws runtime errors when used with empty array or non-positive-int its acceptable to enforce this more strict signature even in non-bleeding edge?
There was a problem hiding this comment.
Yeah, in this case it's okay 👍
|
This pull request has been marked as ready for review. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://3v4l.org/sEB2j
we did not error before this PR: https://phpstan.org/r/2f650341-3dc9-4849-9cac-2bd267a7fb41